amoghrajesh commented on code in PR #60953:
URL: https://github.com/apache/airflow/pull/60953#discussion_r3434233698
##########
providers/hashicorp/src/airflow/providers/hashicorp/_internal_client/vault_client.py:
##########
@@ -200,6 +215,101 @@ def __init__(
self.jwt_role = jwt_role
self.jwt_token = jwt_token
self.jwt_token_path = jwt_token_path
+ self.cache_approle_token = cache_approle_token
Review Comment:
From a brief look I can tell that this is a no-go.
file read + flock on every client access means that every
`get_connection()`, `get_variable()`, etc. hits it. We are adding a disk read
on the hot path of the feature that was supposed to reduce I/O in some way. The
expiry check already exists in `_auth_approle()` right? I don't think it has to
live in here too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
