Vamsi-klu commented on PR #68773:
URL: https://github.com/apache/airflow/pull/68773#issuecomment-4753564406
Thanks @pierrejeambrun for the review on #68148. I opened this follow-up
because GitHub would not let me reopen the original PR after I updated the
branch.
I think the referenced coverage from #65466 does not cover this path: that
test is for the legacy Connexion API on `v2-11-test`, while this PR targets
`main` and the FastAPI `core_api` GET serializers (`PoolResponse` /
`PoolCollectionResponse`). On `main`, the existing unlimited-slots test only
covers the POST/create path; it does not seed a pre-existing `slots=-1` pool
and read it back through `GET /pools/{name}` or `GET /pools`, which is the
regression from #65377.
I also added datamodel-level coverage for
`_sanitize_open_slots(float("inf")) == -1` and `PoolResponse` serialization of
a busy unlimited pool, so this now covers both the route behavior and the
validator behavior.
Local validation passed:
- `ruff check ...`
- datamodel pytest: 2 passed
- focused GET route pytest with `--with-db-init`: 2 passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
