justinmclean commented on PR #540: URL: https://github.com/apache/airflow-steward/pull/540#issuecomment-4760692577
## Correctness No findings. Both grading-schema.json files are valid JSON (parsed clean) and follow the runner's contract: prose_fields as a string list that replaces the default set. Each re-lists all ten of DEFAULT_PROSE_FIELDS before adding its extras, so nothing the runner graded as prose before regresses to exact-match. step-2-prep adds handoff_reason + found_in; step-1-plan adds only handoff_reason — correct, since step-1-plan has no category_x_violations/found_in field. ## Security No findings. Documentation and test-config only; no code paths, inputs, or credentials touched. ## Conventions [advisory] tools/skill-evals/evals/release-prepare/README.md — the "Grading prose steps" section still only documents assertions.json. Not blocking, but a future reader editing fixtures won't know the override exists. Consider a one-line note. No SPDX header on the new grading-schema.json files — expected and consistent, JSON can't hold comments (same as sibling expected.json/assertions.json). README run commands use --directory + --cli, matching the convention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
