Revanth14 commented on PR #68826:
URL: https://github.com/apache/airflow/pull/68826#issuecomment-4770363237
@potiuk heads-up: removing the cap is more involved than just the dependency
bump.
FastAPI 0.137's lazy router inclusion changes the router layer behavior:
`include_router()` no longer leaves only materialized child `APIRoute`s in
`router.routes`; included routers can appear as `_IncludedRouter` wrappers. So
code/tests that iterate `router.routes` assuming every route has `.path`,
`.responses`, etc. now break.
I fixed the execution API part in this PR by assembling the trace-context
dependency at router-build time, but the bump also exposes core API
route-introspection failures, for example:
FAILED core_api/routes/test_routes.py::test_no_auth_routes
AttributeError: '_IncludedRouter' object has no attribute 'path'
So this is effectively a broader FastAPI 0.137 migration that also touches
security-relevant route checks. I can push it through in this PR with a small
route-materialization helper, or split it into a dedicated migration PR. Do you
have a preference? And is the 0.137 migration already tracked anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
