uranusjr commented on code in PR #61019:
URL: https://github.com/apache/airflow/pull/61019#discussion_r3456828270
##########
airflow-core/src/airflow/dag_processing/manager.py:
##########
@@ -430,9 +430,10 @@ def deactivate_stale_dags(
for dag in dags_parsed:
# Dags whose bundle has been removed from config (bundle no longer
active) are stale —
# the processor has stopped parsing their files, so the time-based
check below would never fire.
- if dag.bundle_name in inactive_bundles:
+ # Legacy DAGs with a NULL bundle_name (e.g. from Airflow 2.x) are
also stale, as they will never be parsed.
+ if dag.bundle_name is None or dag.bundle_name in inactive_bundles:
Review Comment:
Can you expand the in-code comment a bit? The context you provided is
critical to understand why the check is needed, but the current wording fails
to capture it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
