uranusjr commented on code in PR #68517:
URL: https://github.com/apache/airflow/pull/68517#discussion_r3457025617
##########
airflow-core/src/airflow/assets/manager.py:
##########
@@ -666,6 +667,7 @@ def _get_or_create_apdr(
rollup_fingerprint: dict,
asset_id: int,
session: Session,
+ allow_reuse: bool = True,
Review Comment:
Is the default needed? This is a private function so we can change all the
call sites instead. A default should be avoided unless necessarily to prevent
calls missing an explicit flag silently do the wrong thing.
Also, the `session` argument should generally be put last.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
