amoghrajesh opened a new pull request, #68880:
URL: https://github.com/apache/airflow/pull/68880
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes - claude sonnet 4.6
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
### What
`task_state_store.clear(all_map_indices=True)` was exposed on the context
object available inside running tasks. Mapped tasks run concurrently, so any
sibling that writes _after_ the clear survives it and the result is
unpredictable and impossible to reason about if you go down a debugging path as
to why it's not cleared :). There is no practical use case for this inside a
running task: the only candidate is of a designated "leader" index doing
post-fleet cleanup which would require polling sibling state, which is not
available on the context object.
### Current behaviour
A task could call `task_state_store.clear(all_map_indices=True)` to attempt
a fleet-wide wipe of state for all map indices of the task. Due to concurrent
execution, the outcome could have a race condition and unreliable.
### Proposed change
Remove `all_map_indices` from `TaskStateStore.clear()` in the task context,
and also remove out the entire plumbing: the field on `ClearTaskStateStore`
comms message, the supervisor forwarding, the client query param, and the
execution API route query param.
The flag is preserved at the backend and core API layer - external callers
(UI, CLI) acting on a completed task group can still wipe all indices cleanly
via the core API.
### Alternative
If you need to clear state across all map indices of a mapped task group, do
it from a downstream task using the CLI / core API which supports it.
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
