shahar1 commented on PR #68856: URL: https://github.com/apache/airflow/pull/68856#issuecomment-4783246482
> > > cc: @shahar1 @potiuk @vincbeck I totally overlooked this and should have warn this before release. Is it possible to yank keycloak and fab as it is not too late only day went? What do you think? I would be happy to help with a follow up release for just two providers. For keycloak case it will be more of a useless case but for fab the logic is wrong :( > > > Edit: Checked and see that we don't even need to create a separate release for Keycloak, as this was the only change for this release. Wanted to get consensus before taking any action > > > > > > Yanking is reserved mostly for catastrophic changes (i.e., provider isn't usable at all, critical security breaches, etc.) - > > so I'd rather not to do it if the provider is still usable except for the broken feature. > > In this case the reverted changes are additive, so I'm not sure that it's justified - please fix me if I'm wrong here. > > I'll be happy to help with an ad-hoc release (+accelerated vote if needed). > > Thank a lot Shahar for the comment and help offer! I want to collect your thinking around what we should do about it and raise awareness. These methods arent called from any piece of code neither while only aimed to be used from core 3.3.0. I would be okay with agreed approach. It is not exactly a catastrophic thing for say Best way IMO - comment directly on the announcement I sent on users@ and dev@, I think that it should be enough at this point. Once the PR is merged, ping me - and I'll create the ad-hoc releases for both + add a comment on the incompatible versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
