amoghrajesh commented on code in PR #68900:
URL: https://github.com/apache/airflow/pull/68900#discussion_r3464512629


##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########


Review Comment:
   The greenback path already works, and calling 
`asset_state_store.get()/set()` from `async def run()` will function correctly 
as long as the greenback portal is active.
   
   The only scenario where it breaks is 
`AIRFLOW_DISABLE_GREENBACK_PORTAL=true`, which is a non default, opted out 
configuration. And in that case the error message already tells you to use 
async equivalents I think, but the gap is just that no async equivalents exist 
yet for `asset_state_store` yet, worth adding that in a follow up, similar to: 
https://github.com/apache/airflow/pull/68232/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to