yuseok89 commented on code in PR #68901:
URL: https://github.com/apache/airflow/pull/68901#discussion_r3465807563
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -580,6 +579,10 @@ def serialize(
return TaskGroupSerialization.serialize_task_group(var)
elif isinstance(var, Param):
return cls._encode(cls._serialize_param(var), type_=DAT.PARAM)
+ elif isinstance(var, DagParam):
+ return cls._encode(
+ cls._serialize_param(Param(default=var._default,
source="dag")), type_=DAT.PARAM
+ )
Review Comment:
Have you tested this? Looking at the code, it seems only _default is stored
and _name is dropped, and since DagParam resolves at runtime via
dag_run.conf[self._name], I think this could be a problem. Or am I misreading
the flow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
