eladkal commented on code in PR #66952:
URL: https://github.com/apache/airflow/pull/66952#discussion_r3469788339


##########
providers/apache/beam/pyproject.toml:
##########
@@ -61,7 +61,11 @@ requires-python = ">=3.10"
 dependencies = [
     "apache-airflow>=2.11.0",
     "apache-airflow-providers-common-compat>=1.12.0",
-    "apache-beam>=2.69.0",
+    "apache-beam>=2.72.0",
+    # For Python>=3.11, the apache-beam package depends on envoy-data-plane.
+    # Currently, there is only one compatible version(1.0.3) of 
envoy-data-plane available for these
+    # Python versions, and it explicitly requires a prerelease version of 
betterproto.
+    "betterproto==2.0.0b6; python_version >= '3.11'",

Review Comment:
   I am not a fan of this.
   this is a beta version from 2023. This is not a case where in a few 
days/weeks things will change and a stable version would be released, is it?
   
   I am not in the details of this so I will leave @potiuk the call here but 
from my point of view we should not deliever stable release with depenedency on 
beta packages.
   Who gurentees that tommorow the author won't remove them from PyPi with a 
thought that there won't be any production impact on anyone?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to