uranusjr commented on code in PR #68938:
URL: https://github.com/apache/airflow/pull/68938#discussion_r3472448174
##########
airflow-core/docs/authoring-and-scheduling/language-sdks/java.rst:
##########
@@ -669,6 +687,36 @@ All ``kwargs`` in the ``coordinators`` config entry are
passed to the
- Seconds to wait for the JVM subprocess to connect after launch.
Increase this if your
JVM startup is slow (e.g. on constrained hardware or with a large
classpath).
+.. note::
+
+ The ``[sdk]`` configuration is read at startup, so changes to
``coordinators`` or
+ ``queue_to_coordinator`` (for example adding ``jvm_args``) only take effect
after you restart the
+ scheduler (or ``airflow standalone``). A rebuilt bundle JAR, by contrast, is
picked up on the next
+ task launch without a restart, because a fresh JVM is spawned per task
instance.
+
+.. _java-sdk/macos:
+
+macOS setup
+-----------
+
+On macOS, pin ``java_executable`` to an absolute path. Homebrew does not
symlink the JDK onto
Review Comment:
I’m not even sure we should mention this in docs. _Technically_ Airflow only
supports Linux.
However I think we say _generally_ pinning `java_executable` to an absolute
path is a good idea regardless. This is especially true in a corporate setting
when the Airflow admin may not even control how the system-wide `java` command
is configured. (Same idea as why in Python land we recommand specifying at
least the Python version.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
