potiuk commented on PR #68964: URL: https://github.com/apache/airflow/pull/68964#issuecomment-4797682247
Thanks for picking this up, @Mady356 — and for the clean diff and the unit test. 🙏 After a closer look, I'm going to lean toward **not adding a dedicated command** here, and it's no fault of the PR — the capability already exists. As the issue notes, since #33347 expired sessions can already be purged through the generic cleanup path: ```bash airflow db clean --tables session --clean-before-timestamp "$(date -u +%Y-%m-%dT%H:%M:%S+00:00)" ``` A `clean-all-expired-sessions` command wraps exactly that call, so it adds CLI surface without new capability. It's also worth noting the `session` table only exists for the legacy Flask-AppBuilder webserver with `[fab] session_backend = database`; Airflow 3's default API server uses stateless JWT auth and has no session table, so this is a shrinking surface we'd rather not grow a dedicated command for. Really do appreciate the effort, and I hope you'll take a swing at another issue — there are plenty where a fresh CLI/db command genuinely fills a gap. I'll close this and the `?`-tagged meta issue as "already covered", but happy to reopen if I've missed a case where the generic command falls short. --- Drafted-by: Claude Code (Opus 4.8); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
