srchilukoori commented on PR #65840: URL: https://github.com/apache/airflow/pull/65840#issuecomment-4813806992
> Hmm - I think I have one more proposal to make "documentation editing" works equally well for "versioned docs" in airflow and "airflow-site" for all the webpage stuff. > > We basically want to have two workflows: > > 1. Update the theme in "airflow-site" and build the site and see any asset changes reflected in the "airflow-site" docs > 2. we build airflow docs locally in "airflow" repo - and changing "sphinx-airflow-theme" locallly and seeing it applied live on local doc server (including generating assets) > > I think that should be possilbe by: > > a) locally building (not fetching) the _gen files - when we always fetch them from whl file, we cannot easily iterate locally on thme > > b) synchronizing - rather than pulling the "airflow-sphinx-theme" between "airflow" and "airflow-site" - that means two -way operations: > > * airflow fetching the theme files from "airflow-site" (not -gen) when running "important uppgrade" and rebuilding _gen rather than fetching them > * ailrflow-site - fetching the "airflow" changes from v3-2-stable when it changes committing those to "airflow-site" > > Do you thin kit's a good and workable approach @srchilukoori ? If so - can you also implement it and add documentaiton to the docs building explaining this process (i.e. what you need to do in order to modify themes when you work on ailrflow, and what happens when you do it for "airflow-site". I added the theme files to the fetch_theme_assets.py, the version bump will pull all files (new + existing). Adding the local build and bi-directional sync will add more complexity, so I prefer to keep it to forward sync from airflow-site to airflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
