dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql
odbc hook
URL: https://github.com/apache/airflow/pull/6850#discussion_r362747004
##########
File path: setup.py
##########
@@ -275,6 +275,7 @@ def write_version(filename: str =
os.path.join(*["airflow", "git_version"])):
]
mssql = [
'pymssql~=2.1.1',
+ 'pyodbc',
Review comment:
>So it seems you can just pass DSN as the HOST parameter.
>It also reads my Trusted_Connection=yes, from odbc.ini so I can use
Kerberos to connect.
>Don't know if you've seen this, perhaps easier than unpacking the
ODBC-specific parameters and building the string
Yes you are welcome to use DSN only. But not everyone wants to bother
defining a DSN when you can just define everything you need in airflow conn
uri. E.g. me :)
But this hook intends to support either DSN or driver + params or any
reasonable combination.
There is no need to force people to define a DSN.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
