shivaam commented on PR #68961: URL: https://github.com/apache/airflow/pull/68961#issuecomment-4814955871
@ferruzzi thanks, this makes sense. I split the independent `callback.data` persistence fix out into #69073 so it can be reviewed separately from the failure-behavior question. That PR is scoped to `Deadline.handle_miss()` persisting the callback context/routing data correctly. For this PR, I agree that always firing the Deadline Alert on failure is too broad as the default. I will rework this toward an opt-in `DeadlineAlert` flag (name TBD, maybe something like `fire_on_failure` / `alert_on_failure`, defaulting to `False`) so users can choose this behavior for the cases where a failed run means the deadline is inevitably missed. The prune-hook and UI/manual-failure options also make sense to me, but I think those can be tracked as follow-up issues unless you think they should be included in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
