guan404ming commented on code in PR #68991:
URL: https://github.com/apache/airflow/pull/68991#discussion_r3485418650
##########
dev/breeze/src/airflow_breeze/utils/packages.py:
##########
@@ -683,6 +683,27 @@ def get_cross_provider_dependent_packages(provider_id:
str) -> list[str]:
return get_provider_dependencies()[provider_id]["cross-providers-deps"]
+def get_cross_provider_dependencies_for_extras(provider_id: str) -> list[str]:
Review Comment:
Nit (non-blocking): this helper and the inline extras logic at
packages.py:982-984 now repeat the same "skip suspended + skip
already-required" rule. The exact two paths that drifted apart and caused this
bug. Could extract a shared predicate so there's one source of truth, but it's
only two conditions and the current code is correct, so fine to leave as-is.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
