uranusjr commented on code in PR #68548: URL: https://github.com/apache/airflow/pull/68548#discussion_r3487265289
########## task-sdk/src/airflow/sdk/coordinators/typescript/coordinator.py: ########## @@ -0,0 +1,158 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""TypeScript runtime coordinator that launches a Node.js subprocess for task execution.""" + +from __future__ import annotations + +import os +import pathlib +from typing import TYPE_CHECKING, Any + +import attrs +import structlog +import yaml + +from airflow.sdk.coordinators._subprocess import SubprocessCoordinator +from airflow.sdk.execution_time.schema import get_schema_version_migrator + +if TYPE_CHECKING: + from collections.abc import Sequence + + from structlog.typing import FilteringBoundLogger + + from airflow.sdk.api.datamodels._generated import TaskInstance + +log: FilteringBoundLogger = structlog.get_logger(logger_name="coordinators.typescript") + +BUNDLE_FILENAME = "bundle.mjs" +METADATA_FILENAME = "airflow-metadata.yaml" + + +def _validate_schema_version(instance, _, value) -> str: + return get_schema_version_migrator().resolve_version(str(value)) + + [email protected] +class _TypescriptBundle: + path: pathlib.Path + schema_version: str = attrs.field(validator=_validate_schema_version) + + +def _read_bundle_metadata(metadata_path: pathlib.Path) -> dict[str, Any]: + if not metadata_path.is_file(): + raise ValueError(f"missing {METADATA_FILENAME}") + + try: + data = yaml.safe_load(metadata_path.read_text(encoding="utf-8")) + except OSError as exc: + raise ValueError(f"cannot read {METADATA_FILENAME}: {exc}") from exc + except yaml.YAMLError as exc: + raise ValueError(f"cannot parse {METADATA_FILENAME}: {exc}") from exc + + if not isinstance(data, dict): + raise ValueError(f"{METADATA_FILENAME} must contain a mapping") + return data + + +def _supervisor_schema_version(metadata: dict[str, Any]) -> str: + sdk = metadata.get("sdk") + if not isinstance(sdk, dict): + raise ValueError("missing sdk metadata mapping") + + value = sdk.get("supervisor_schema_version") + if not isinstance(value, str) or not value: + raise ValueError("missing or invalid sdk.supervisor_schema_version") + return value + + +def _find_bundle(bundles_root: Sequence[pathlib.Path]) -> _TypescriptBundle: + """ + Locate the ``.mjs`` entry point in *bundles_root*. + + Scans each configured directory for ``bundle.mjs`` and reads the sibling + ``airflow-metadata.yaml`` for the bundle's supervisor schema version. + + This is an ordered fallback search, not Dag/task-aware multi-bundle + routing. The first bundle found wins. A future version can use the + metadata's ``dags`` section together with ``TaskInstance.dag_id`` and + ``TaskInstance.task_id`` to select the bundle that owns a specific task. + """ + for root in bundles_root: + candidate = root / BUNDLE_FILENAME + if not candidate.is_file(): + continue + metadata = _read_bundle_metadata(root / METADATA_FILENAME) + log.debug("Selected TypeScript bundle", path=candidate, root=root) + return _TypescriptBundle( + path=candidate, + schema_version=_supervisor_schema_version(metadata), Review Comment: If metadata in a bundle is malformed, this would cause an unhandled ValueError bubble out of the coordinator. This is inconsistent with other coordinators; both Java and Executable would discard the artifact with a warning and keep scanning instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
