potiuk commented on PR #69106: URL: https://github.com/apache/airflow/pull/69106#issuecomment-4826354430
@vincbeck — one judgement call to flag here: I removed the `if dag_id in RESOURCE_DETAILS_MAP.keys(): return dag_id` short-circuit in `resource_name()`. I couldn't find a call site that legitimately relies on passing a bare reserved resource name (`DAGs` / `DAG Runs`) as the `dag_id` arg — every caller passes a real `dag_id`, and the global-resource auth check is done separately — so removing it looks safe. But you've been in this code recently; if there *was* an intended use for that mapping that I'm missing, say so and I'll rework it. (I kept the already-prefixed `DAG:` branch, which is clearly load-bearing for idempotency.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
