Dotify71 opened a new pull request, #69114:
URL: https://github.com/apache/airflow/pull/69114

   Closes #68754
   
   ### What changes did you make?
   
   - Updated the `key` column in `XCom.tsx` and `TaskStateStore.tsx` to use the 
existing `TruncatedText` component instead of a plain `Text`/`Box`. This 
ensures extremely long, unbroken keys are truncated to two lines with an 
ellipsis, and the full value is always accessible on hover. This is consistent 
with how `run_id` is handled elsewhere in the UI and prevents the table from 
expanding beyond its container.
   - Adjusted the collapse button in `DetailsLayout.tsx` by adding 
`transform="translateX(-100%)"` (or `100%` for RTL). This shifts the button so 
it sits entirely within the resize handle gutter between the two panels, 
preventing it from overlapping the content of the right panel.
   
   ### Why did you make these changes?
   
   Long, unbroken strings in the `key` column were causing the table to exceed 
its container width, resulting in the table content overlapping the adjacent 
details panel and its expand/collapse button. This re-submission addresses the 
feedback from the previous review:
   - Uses `TruncatedText` (the established pattern for long strings) rather 
than a bare `wordBreak` override
   - Fixes the collapse button position so it no longer overlaps either panel's 
content
   
   ### Before / After
   
   | Before | After |
   |--------|-------|
   | Long keys push the table out of bounds, overlap with the panel UI | Keys 
are neatly truncated with ellipsis, hover shows full value |
   | Collapse button sits on top of the right panel content | Collapse button 
sits in the resize gutter between panels |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to