jason810496 commented on code in PR #68713:
URL: https://github.com/apache/airflow/pull/68713#discussion_r3491192390
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -198,6 +198,60 @@ def start(self) -> None:
scheduler_job_id=self.scheduler_job_id,
)
+ def _coordinator_extra(self, queue: str | None) -> dict[str, Any] | None:
Review Comment:
IMO, the coordinator is not belongs to k8s provider so I prefer to keep it
as private helper function. Perhaps I can rename it with _get_ prefix as
follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]