hussein-awala commented on code in PR #64611:
URL: https://github.com/apache/airflow/pull/64611#discussion_r3494097098
##########
task-sdk/src/airflow/sdk/execution_time/comms.py:
##########
@@ -1115,6 +1116,7 @@ class GetAssetEventByAssetAlias(BaseModel):
before: AwareDatetime | None = None
limit: int | None = None
ascending: bool = True
+ extra: dict[str, str] | None = None
Review Comment:
`extra` is just an optional query param on the existing `/by-asset` and
`/by-asset-alias` endpoints, not a new endpoint or a request/response body
field. The other params there (`name`, `uri`, `after`, `before`, `limit`,
`ascending`) are all plain query params too, and none of them are
cadwyn-versioned.
The thing is, cadwyn is built for the "older client → newer server"
direction. It can't help with the case you're describing (a newer SDK hitting
an older server) because the old server simply has no code for the param. What
actually happens there is the old server just ignores the unknown `extra` query
param and returns unfiltered events. So you'd get more events than you filtered
for, but nothing breaks. A cadwyn migration wouldn't change that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
