ashutosh264 commented on PR #68904: URL: https://github.com/apache/airflow/pull/68904#issuecomment-4840774186
> Maybe for performance reason (less monaco IDE mounted at once on the same page)? That still makes the content of the conf available through an extra click, and there are plenty of other tables with monaco columns (xcoms, assets, etc...) that currently work fine. If we want to change this, we probably need to change it for all tables and unless it's proven to be a performance bottleneck (with experiment and metrics) I wouldn't be in favor of going in that direction. Also if we want to explore it, I would create a separate PR because we probably want to discuss more about this and not block the 'display config column by default' part. Thanks for the review, agreed on keeping Monaco inline for consistency with XCom/Assets/etc. I've dropped the custom preview/dialog (DagRunConfCell) and reverted to the existing RenderedJsonField collapsed cell. The PR now only makes the Conf column visible by default. Removed the newsfragment per your comment. Rebased onto the latest main to fix CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
