ephraimbuddy commented on code in PR #61550:
URL: https://github.com/apache/airflow/pull/61550#discussion_r3501111336
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:
##########
Review Comment:
Are we intentionally using the latest Dag/DagModel for `allowed_run_types`
even when `bundle_version` points at an older Dag version? The rest of this
path now derives params/timetable/tasks from the requested version, so this can
reject a run v1 allows or allow a run v1 disallows. If current policy should
govern triggerability, please add a test for that; otherwise this should move
to `context_dag.allowed_run_types` after version resolution.
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:
##########
Review Comment:
core_api/routes/public/assets.py line 449 has the same issue
##########
airflow-core/src/airflow/serialization/definitions/dag.py:
##########
@@ -653,7 +656,25 @@ def create_dagrun(
self.validate_partition_key(partition_key)
Review Comment:
`create_dagrun()` still validates `partition_key` against `self` before
resolving the requested bundle version. In the API trigger path `self` is the
latest Dag, so `bundle_version="v1"` can still fail for a partitioned v1 if
latest v2 is not partitioned. Please resolve the requested Dag version first
and validate against that Dag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
