amoghrajesh commented on code in PR #69178:
URL: https://github.com/apache/airflow/pull/69178#discussion_r3503297282
##########
airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_state_store.py:
##########
@@ -78,6 +78,16 @@ def test_get_missing_ti_returns_404(self, client:
TestClient):
assert response.status_code == 404
assert "Task instance" in response.json()["detail"]["message"]
+ def test_get_key_with_slash(self, client: TestClient,
create_task_instance: CreateTaskInstance):
+ """Keys containing slashes must be routed correctly — route uses
{key:path}."""
Review Comment:
```suggestion
```
##########
airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_state_store.py:
##########
@@ -203,6 +213,15 @@ def test_put_missing_ti_returns_404(self, client:
TestClient):
assert response.status_code == 404
+ def test_put_key_with_slash(self, client: TestClient,
create_task_instance: CreateTaskInstance):
+ """Keys containing slashes must be stored and retrieved correctly —
route uses {key:path}."""
Review Comment:
```suggestion
```
##########
airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_state_store.py:
##########
@@ -231,6 +250,16 @@ def test_delete_only_targets_one_key(self, client:
TestClient, create_task_insta
assert client.get(_api_url(ti.id, "job_id")).status_code == 404
assert client.get(_api_url(ti.id, "checkpoint")).json() == {"value":
"b"}
+ def test_delete_key_with_slash(self, client: TestClient,
create_task_instance: CreateTaskInstance):
+ """Keys containing slashes must be deletable — route uses
{key:path}."""
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
