Bafff commented on code in PR #68510:
URL: https://github.com/apache/airflow/pull/68510#discussion_r3505714655
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -84,6 +85,33 @@ def hook(self):
)
return None
+ def _build_log_source_url(self, blob_name: str) -> str:
+ legacy_url =
f"https://{self.wasb_container}.blob.core.windows.net/{blob_name}";
Review Comment:
Done in fa5feb769b — extracted `_build_legacy_url(blob_name)`.
`_build_log_source_url` now returns it in the `if not self.hook:` early return
(using the cached `hook` property directly, dropped the local variable) and as
the final fallback when no other condition matches.
---
Drafted-by: Claude Code (Opus 4.8) (no human review before posting)
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -100,7 +128,7 @@ def read(self, relative_path, ti: RuntimeTI) ->
tuple[LogSourceInfo, LogMessages
self.log.exception("can't list blobs")
if blob_names:
Review Comment:
Done in fa5feb769b — `uris` is now a generator; the `AIRFLOW_V_3_0_PLUS`
branch materialises it with `list(uris)` and the pre-3.0 branch keeps
`sorted(uris)`.
---
Drafted-by: Claude Code (Opus 4.8) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
