phanikumv commented on code in PR #68997:
URL: https://github.com/apache/airflow/pull/68997#discussion_r3505856312
##########
providers/standard/src/airflow/providers/standard/sensors/external_task.py:
##########
@@ -263,7 +263,7 @@ def __init__(
self.check_existence = check_existence
self._has_checked_existence = False
self.deferrable = deferrable
- self.poll_interval = poll_interval
+ self.poke_interval = poke_interval
Review Comment:
Assigning `self.poke_interval = poke_interval` here overwrites the value the
base class already coerced/validated during `super().__init__()`, and since
`poke_interval` is now an explicit arg it never reaches the base at all. So a
`timedelta` stays a `timedelta` (breaks time.sleep/asyncio.sleep in the poke
loop) and a negative value skips validation.
Coercing it the same way the base does fixes both, keeps the 2.0 default,
and doesn't touch the plain-float path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
