FrankYang0529 commented on PR #68778:
URL: https://github.com/apache/airflow/pull/68778#issuecomment-4855628153

   > How is NONE different from HOLD? I did a brief mental check and from what 
I can tell internals seem to treat them the same. This is particularly a 
problem since there’s zero documentation available here. Maybe we should add 
some?
   
   Originally, I used `NONE` for non-RollupMapper and `HOLD` for the 
RollupMapper. However, both have same behavior. They all follow `WaitPolicy` to 
decide whether a partitioned Dag run should fire. I remove the `NONE`. The 
non-rollup mappers and a window's first materialization now use `HOLD` as the 
default value.
   
   For document, we have it in both 
`airflow-core/src/airflow/partition_mappers/rerun_policy.py` and 
`task-sdk/src/airflow/sdk/definitions/partition_mappers/rerun_policy.py`. Let 
me know if you'd like the docs expanded anywhere else. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to