henry3260 commented on code in PR #68682:
URL: https://github.com/apache/airflow/pull/68682#discussion_r3508025541
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py:
##########
@@ -485,6 +486,7 @@ def get_dag_runs(
offset: QueryOffset,
run_after: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("run_after", DagRun))],
logical_date: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("logical_date", DagRun))],
+ partition_date: Annotated[RangeFilter,
Depends(datetime_range_filter_factory("partition_date", DagRun))],
Review Comment:
> This and `partition_date_start` `partition_date_end` looks duplicated.
>
> Can't we get away with just one of them, ideally just
`partition_date_start`, because the other two are implying ugly custom code in
the view implementation.
Thanks, good point. I checked the airflowctl use case and we only need the
date-only `partition_date_start` / `partition_date_end` query params for GET
Dag runs, plus `order_by=partition_date`. I removed the duplicate generic
`partition_date_*` datetime filters from this endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
