This is an automated email from the ASF dual-hosted git repository.
shahar1 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 9b8c03f6739 Trim redundant comments from KubernetesExecutor
lazy-Manager tests (#69216)
9b8c03f6739 is described below
commit 9b8c03f67396eaaea7563606d414eed48b019407
Author: Shahar Epstein <[email protected]>
AuthorDate: Wed Jul 1 22:30:00 2026 +0300
Trim redundant comments from KubernetesExecutor lazy-Manager tests (#69216)
The added tests carried a multi-line docstring and inline comments that
restated what the test names and assertions already convey. Reducing them
to the minimum keeps the intent while dropping the narration, following up
on review feedback for #68800.
---
.../unit/cncf/kubernetes/executors/test_kubernetes_executor.py | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git
a/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py
b/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py
index b3129c15ae9..285b263b064 100644
---
a/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py
+++
b/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py
@@ -2356,13 +2356,7 @@ class TestKubernetesExecutor:
]
def test_init_does_not_create_manager_process(self):
- """
- Constructing the executor must not spawn a ``multiprocessing.Manager``.
-
- The API server builds a ``KubernetesExecutor`` purely to call
``get_task_log()`` for
- RUNNING tasks and never starts it. Eagerly creating the Manager in
``__init__`` leaked an
- orphaned ``serve_forever`` process per API-server worker.
- """
+ """Constructing the executor must not spawn a
``multiprocessing.Manager``."""
executor = KubernetesExecutor()
assert executor._manager is None
@@ -2391,7 +2385,6 @@ class TestKubernetesExecutor:
"""``end()`` on an executor that was never started must not raise."""
executor = KubernetesExecutor()
- # Must not raise even though no Manager/queues were ever created.
executor.end()
assert executor._manager is None
@@ -2954,7 +2947,6 @@ class TestKubernetesExecutorMultiTeam:
team_b_executor.job_id = 2
try:
- # Queues are created lazily in start(), so each team executor gets
its own.
team_a_executor.start()
team_b_executor.start()
