uranusjr commented on code in PR #67381:
URL: https://github.com/apache/airflow/pull/67381#discussion_r3509323887


##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/backfills.py:
##########
@@ -69,6 +70,27 @@ class BackfillCollectionResponse(BaseModel):
     total_entries: int
 
 
+class BackfillDagRunResponse(BaseModel):
+    """Serializer for a single BackfillDagRun entry with joined DagRun 
state."""
+
+    id: NonNegativeInt
+    backfill_id: NonNegativeInt
+    dag_run_id: NonNegativeInt | None
+    logical_date: datetime | None
+    partition_key: str | None
+    sort_ordinal: int
+    exception_reason: str | None
+    dag_run_state: DagRunState | None = Field(default=None, 
validation_alias=AliasPath("dag_run", "state"))
+    dag_run_run_id: str | None = Field(default=None, 
validation_alias=AliasPath("dag_run", "run_id"))

Review Comment:
   Do we need to expose `DagRun.id`? In most places we only expose 
`DagRun.run_id` under `dag_run_id` instead, with an additional `dag_id` field 
to uniquely identify the run.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to