dstandish commented on code in PR #69146:
URL: https://github.com/apache/airflow/pull/69146#discussion_r3509480272
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -2333,6 +2350,15 @@ def main():
):
state, _, error = run(ti, context, log)
context["exception"] = error
+ # run() funnels every failure path into `error` rather than
+ # re-raising, so the worker span never sees the exception via
+ # propagation. Mark it here, where the worker span is in scope
+ # regardless of trace detail level.
+ if error is not None:
+ span.record_exception(error)
+ span.set_status(
Review Comment:
so what you are saying is, when it's a timeout, the status gets market at
worker span, but otherwise it's a little deeper in
that's right, and i think that's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
