anmolxlight commented on code in PR #68557:
URL: https://github.com/apache/airflow/pull/68557#discussion_r3510303944
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_client.py:
##########
@@ -51,26 +51,34 @@ def _disable_verify_ssl() -> None:
_import_err = e
-def _enable_tcp_keepalive() -> None:
+def _enable_tcp_keepalive(configuration: Configuration) -> None:
Review Comment:
Good point — a private function shouldn't be part of the public interface
that another provider imports. I've made the following changes:
1. Renamed the implementation to `enable_tcp_keepalive(configuration)` — a
public function that external code should use
2. Kept `_enable_tcp_keepalive` as a thin deprecated wrapper (accepts
optional config for backward compat with both the old no-arg and the new arg
signatures) that issues a `DeprecationWarning`
3. Updated all internal callers in `hooks/kubernetes.py`,
`kubernetes_engine.py`, and `get_kube_client()` to call the public function
directly
Tests and imports have been updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
