hkc-8010 commented on PR #68008: URL: https://github.com/apache/airflow/pull/68008#issuecomment-4862794747
@Vamsi-klu Good catch, fixed. \`_purge_task_instances_without_heartbeats\` now sets \`task_callback_type\` the same way \`_process_executor_events\` does for the external-kill path: \`UP_FOR_RETRY\` if \`ti.is_eligible_to_retry()\` else \`FAILED\`, computed before \`handle_failure()\`. Added \`test_heartbeat_timeout_sets_callback_type_param\`, parametrized over a retry-eligible case (\`max_tries=1\`) and a non-eligible case (\`max_tries=0\`), asserting both the callback request's \`task_callback_type\` and the TI's final state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
