potiuk commented on code in PR #66141:
URL: https://github.com/apache/airflow/pull/66141#discussion_r3519933013
##########
airflow-core/src/airflow/api_fastapi/execution_api/versions/__init__.py:
##########
@@ -66,6 +67,10 @@
AddAssetsByAliasEndpoint,
AddPartitionDateField,
),
+ Version(
+ "2026-06-01",
Review Comment:
Please reconcile before this merges: the version module is named
`v2026_07_01.py`, but this label is `"2026-06-01"`. They should agree. Two ways:
- If `2026-06-01` is correct, rename the file to `v2026_06_01.py` (the
import above and this entry's position between `2026-06-30` and `2026-04-06`
are already right for that date).
- If `2026-07-01` was intended, change this label to `"2026-07-01"` **and**
move the whole `Version(...)` block above the `2026-06-30` entry so the
descending order stays correct.
It works today (Cadwyn keys off the string, and `2026-06-01` is correctly
ordered), so this isn't a runtime bug — but the filename/label disagreement is
a trap for the next person editing the version bundle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
