moomindani commented on code in PR #69182:
URL: https://github.com/apache/airflow/pull/69182#discussion_r3522363369
##########
providers/databricks/src/airflow/providers/databricks/operators/databricks.py:
##########
@@ -1542,21 +1551,71 @@ def _get_task_base_json(self) -> dict[str, Any]:
"""Get the base json for the task."""
raise NotImplementedError()
+ def _retry_settings(self) -> dict[str, Any]:
+ """Databricks-native task retry settings that were explicitly
provided."""
+ settings: dict[str, Any] = {}
+ if self.max_retries is not None:
+ settings["max_retries"] = int(self.max_retries)
+ if self.min_retry_interval_millis is not None:
+ settings["min_retry_interval_millis"] =
int(self.min_retry_interval_millis)
+ if self.retry_on_timeout is not None:
+ retry_on_timeout = self.retry_on_timeout
+ if isinstance(retry_on_timeout, str):
+ retry_on_timeout = retry_on_timeout.strip().lower() in
("true", "1", "yes")
+ settings["retry_on_timeout"] = bool(retry_on_timeout)
+ return settings
+
+ def _has_retry_settings(self) -> bool:
+ """Whether any Databricks-native retry field is explicitly
configured."""
+ if self._retry_settings():
+ return True
+ task_config = getattr(self, "task_config", {}) or {}
+ return any(
+ task_config.get(key) is not None
+ for key in ("max_retries", "min_retry_interval_millis",
"retry_on_timeout")
+ )
+
+ def _resolved_max_retries(self) -> int | None:
+ """Return the resolved ``max_retries`` value, with operator args
taking precedence."""
+ task_config = getattr(self, "task_config", {}) or {}
+ max_retries = self.max_retries if self.max_retries is not None else
task_config.get("max_retries")
+
+ if isinstance(max_retries, bool) or max_retries is None:
+ return None
+ if isinstance(max_retries, str):
+ try:
+ return int(max_retries)
+ except ValueError:
Review Comment:
Minor: an unparsable `max_retries` string (e.g. a bad template render)
silently resolves to "no retry limit configured" rather than surfacing the
misconfiguration, which falls back to waiting for the parent run instead of
failing fast. Not blocking — the degraded behavior is the safe direction — but
a log warning here would help a user notice the bad value.
---
Drafted-by: Claude Code (Fable 5); reviewed by @moomindani before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
