Lee-W commented on code in PR #69368:
URL: https://github.com/apache/airflow/pull/69368#discussion_r3522986890
##########
providers/fab/src/airflow/providers/fab/www/session.py:
##########
@@ -30,19 +30,23 @@ class _LazySafeSerializer:
Returns bytes (suitable for database BLOB columns).
"""
- def dumps(self, session_dict):
- encoder = msgspec.msgpack.Encoder(
- enc_hook=lambda obj: str(obj) if isinstance(obj, LazyString) else
obj
- )
- return encoder.encode(dict(session_dict))
-
- def loads(self, data):
- decoder = msgspec.msgpack.Decoder()
- return decoder.decode(data)
-
- # optional old API
- encode = dumps
- decode = loads
+ def dumps(self, session_dict):
Review Comment:
```suggestion
def dumps(self, session_dict):
```
this is clearly wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
