potiuk commented on PR #66925: URL: https://github.com/apache/airflow/pull/66925#issuecomment-4883978972
Thanks for taking this on, but I'm going to close this one — it isn't the right way to do the decoupling. The goal is to make sure the **Task SDK does not use SQLAlchemy at all**. This change doesn't achieve that — it just *moves* the session usage (threading in a caller-supplied session) rather than *removing* it, and it passes a **raw session** through, which is actually worse than importing the session helper from `airflow-core`. Getting this right really requires some expert knowledge of what we're trying to achieve with the Task SDK isolation, so it isn't a great fit as a task for someone newer to the codebase — I'd suggest picking up something that doesn't require that depth of context. Thanks for the effort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
