Abdulrehman-PIAIC80387 commented on PR #68327:
URL: https://github.com/apache/airflow/pull/68327#issuecomment-4889945362
Thanks for the thorough review, @Vamsi-klu! Both nits are resolved in
`1dae34a2e4`:
- Marked the `{}` case as a control (comment in the `parametrize`), so it's
clear only `soft_fail` / `never_fail` were the regressions.
- Reworded the docstring to point at the runtime `AirflowRescheduleException
→ UP_FOR_RESCHEDULE` coverage in `test_ok_with_reschedule` /
`test_fail_with_reschedule`, so the SDK-level re-raise and that path together
pin the end-to-end behavior.
Also rebased onto latest `main`. Further reviews are welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
