jason810496 commented on code in PR #69434:
URL: https://github.com/apache/airflow/pull/69434#discussion_r3527277537
##########
.github/workflows/publish-docs-to-s3.yml:
##########
@@ -322,15 +322,37 @@ jobs:
key: cache-docs-inventory-v1
id: restore-docs-inventory-cache
- name: "Building docs with --docs-only flag using ${{ inputs.ref }}
reference breeze"
+ id: build-sphinx-docs
env:
INCLUDE_DOCS: ${{ needs.build-info.outputs.include-docs }}
INCLUDE_COMMITS: ${{ startsWith(inputs.ref, 'providers') && 'true'
|| 'false' }}
FAIL_ON_INVENTORIES: ${{ inputs.ignore-missing-inventories != true
&& '--fail-on-missing-third-party-inventories' || '' }}
- run: >
- breeze build-docs ${INCLUDE_DOCS} --docs-only ${FAIL_ON_INVENTORIES}
+ run: |
+ # The Java SDK docs are built with Dokka by the separate
build-java-sdk-docs job;
+ # java-sdk is not a Sphinx package, so it must not be passed to
breeze build-docs.
+ SPHINX_INCLUDE_DOCS=""
+ for package in ${INCLUDE_DOCS}; do
+ if [[ "${package}" != "java-sdk" ]]; then
+ SPHINX_INCLUDE_DOCS="${SPHINX_INCLUDE_DOCS} ${package}"
+ fi
+ done
+ if [[ -n "${INCLUDE_DOCS}" && -z "${SPHINX_INCLUDE_DOCS// /}" ]];
then
+ # Only java-sdk was requested. An empty package list means "build
everything"
+ # to breeze, so skip the Sphinx build entirely instead. The marker
file keeps
+ # the docs artifact non-empty for the upload/download steps.
Review Comment:
I addressed all the review comments in
https://github.com/apache/airflow/pull/69434/commits/c3b169083e40da35f3a61b7019214609f472b623.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
