VladaZakharova commented on code in PR #68930: URL: https://github.com/apache/airflow/pull/68930#discussion_r3527667131
########## providers/google/tests/system/google/resources_cleanup/.airflowignore: ########## @@ -0,0 +1 @@ +* Review Comment: Thanks, that makes sense. The intent is not to add a new general Airflow CLI. This is Google provider system-test tooling, so I’m keeping it under `providers/google/tests/...` and making sure it can be run by any Airflow contributor with a GCP project and the required Cloud Asset Inventory/delete permissions, not only by Google-internal users. For the extra files: - `__init__.py` inside `airflow_google_provider_resource_cleanup` is only there because this is an importable helper package with a console entry point and unit tests. - The `config/` and `data/` package markers are not needed, so I removed them. - `.gitignore` is only for generated local cleanup output like synced resource files and HTML output. - `.airflowignore` is not essential unless this folder is ever placed under a DAGs directory; I can remove it if preferred. 4. For CI, the unit tests are under `providers/google/tests/unit/google/resources_cleanup`, so they should be picked up with the Google provider unit tests. I can also add explicit CI wiring if that is preferred. I don’t think Breeze integration is the right first step unless maintainers want this to become a broader developer workflow. The tool is credentialed and destructive by nature, so keeping it scoped as Google provider test tooling seems safer and clearer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
