phanikumv commented on code in PR #69444:
URL: https://github.com/apache/airflow/pull/69444#discussion_r3528202751


##########
java-sdk/README.md:
##########
@@ -185,13 +220,109 @@ newlines, which does not work well in a Gradle 
properties file.
 credentials instead: `ASF_NEXUS_USERNAME`, `ASF_NEXUS_PASSWORD`, `SIGNING_KEY`,
 and `SIGNING_PASSWORD`. This is especially useful on e.g. CI.
 
+*NOTE:* We enable Gradle's configuration cache globally, but the staging tasks
+(`publishToApache`, `closeApacheStagingRepository`, 
`releaseApacheStagingRepository`)
+talk to the Nexus REST API and are not configuration-cache compatible. Hence
+the `--no-configuration-cache` flag on the release commands.
+
 ### Verify the upload
 
-Verify all artifacts have been released correctly to the
-[ASF Nexus 
server](https://repository.apache.org/#nexus-search;quick~org.apache.airflow).
+Under *Staging Repositories* on the
+[ASF Nexus server](https://repository.apache.org/), open the closed repository
+and verify it contains all modules, each with its jar, `-sources.jar`,
+`-javadoc.jar` (where applicable), `.pom`, and `.asc` signature.
 
 Check *Updated by* (should be your ID), *Uploaded Date*, and *Last Modified*.
 
+### Upload the source package
+
+The closed staging repository from the previous step is the convenience-binary
+URL you link in the vote.
+
+The signed source package is the artifact the vote is formally on; the Maven
+artifacts are convenience binaries. The `sourceRelease` task builds it from the
+committed `java-sdk` sources (`LICENSE` and `NOTICE` included) and produces its
+signature and checksum in one step:
+
+```bash
+# Signing uses your local gpg keyring, so have your key/passphrase ready.
+./gradlew sourceRelease -PgitRef=java-sdk/1.0.0-beta1-rc1

Review Comment:
   `gradle.properties` sets `org.gradle.configuration-cache=true` globally, and
    the README documents `sourceRelease` without `--no-configuration-cache` 
(unlike the staging tasks, which you correctly flagged). Getting the below 
error on this branch:
   
   ```
     > Task :sourceTarball FAILED
     - Task `:sourceTarball` of type `org.gradle.api.tasks.Exec`: cannot 
serialize
       Gradle script object references as these are not supported with the 
configuration cache.
     BUILD FAILED
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to