Dev-iL opened a new pull request, #69469:
URL: https://github.com/apache/airflow/pull/69469
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
related:
- #68453
- #68496
Mirrors the async default switch: a bare `postgresql://` or legacy
`postgres://` / `postgres+psycopg2://` `sql_alchemy_conn` is now rewritten to
`postgresql+psycopg://` instead of `postgresql+psycopg2://`. An explicit
`postgresql+psycopg2://` URL is never rewritten and keeps working as long as
`apache-airflow-providers-postgres[psycopg2]` is installed.
**This PR touches core only - there will be separate PRs for providers.**
### What changed
- `_upgrade_postgres_metastore_conn`
(`airflow-core/src/airflow/configuration.py`): `good_scheme` changed from
`postgresql+psycopg2` to `postgresql+psycopg`. `bad_schemes` is unchanged.
- `prepare_engine_args` (`airflow-core/src/airflow/settings.py`): the
psycopg2-specific `executemany_mode`/`executemany_batch_page_size` tuning now
follows the **actually-configured** `SQL_ALCHEMY_CONN` scheme, not whether the
`psycopg` package happens to be importable.
- New sync-driver section in `airflow-core/docs/howto/set-up-database.rst`,
mirroring the existing async section, documenting the new default and how to
restore psycopg2 via the provider's `[psycopg2]` extra.
- Updated remaining hardcoded `postgresql+psycopg2://` example connection
strings across docs and reference deployment configs (Docker Compose
quick-start, Helm chart values, CI backend config, task-sdk integration tests,
a few executor/logging docs) that would otherwise break for anyone following
them as-is now that the postgres provider no longer bundles psycopg2-binary by
default.
- Newsfragment: `airflow-core/newsfragments/68453.improvement.rst`.
### Test plan
-
`airflow-core/tests/unit/core/test_configuration.py::test_upgrade_postgres_metastore_conn`
updated to assert `postgresql+psycopg`, plus a case confirming an explicit
`postgresql+psycopg2://` value is left untouched.
- `airflow-core/tests/unit/core/test_sqlalchemy_config.py`: new parametrized
test covering all four combinations of `{postgresql+psycopg2,
postgresql+psycopg} × {psycopg3 available, not available}`, confirming the
executemany tuning follows the configured scheme rather than package
importability.
- Verified behaviorally against bare/explicit-psycopg2/explicit-psycopg
`sql_alchemy_conn` values with no live Postgres required.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Sonnet 5)
Generated-by: Claude Code (Sonnet 5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Sonnet 5 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
