Dev-iL opened a new pull request, #69493:
URL: https://github.com/apache/airflow/pull/69493
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
related:
- #68453
depends on:
- https://github.com/apache/airflow/pull/69474
`register_adapter(list/dict, Json)` in `BigQueryToPostgresOperator` is
psycopg2-specific and previously ran unconditionally, forcing psycopg2 to be
importable even when the resolved `PostgresHook` connection is actually on
psycopg3 (where it's a no-op). Only import and call it when `PostgresHook` is
actually on the psycopg2 path.
> **Note:** this module only imports cleanly without psycopg2 installed once
`apache-airflow-providers-postgres` itself stops hard-requiring psycopg2 —
that's the companion change in **psycopg3-sync-postgres**. This PR should be
merged after (or at least released alongside) that one; see the code comment at
the import site in `bigquery_to_postgres.py`.
### What changed
-
`providers/google/src/airflow/providers/google/cloud/transfers/bigquery_to_postgres.py`:
the `from psycopg2.extensions import register_adapter` / `from psycopg2.extras
import Json` imports and the `register_adapter(...)` calls are now conditional
on `not PostgresHook.USE_PSYCOPG3`, guarded inside `postgres_hook`, with a
comment documenting the dependency on the postgres provider's own guard fix.
### Test plan
- Existing `bigquery_to_postgres` test suite passes.
- New tests: `test_adapters_to_json_registered_on_psycopg2_path`,
`test_adapters_not_registered_on_psycopg3_path`,
`test_bigquery_to_postgres_module_imports_without_psycopg2` (simulates psycopg2
absent via `sys.modules` patching, confirms clean import).
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Code (Sonnet 5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
