SameerMesiah97 commented on code in PR #69185:
URL: https://github.com/apache/airflow/pull/69185#discussion_r3532275473
##########
airflow-core/src/airflow/callbacks/callback_requests.py:
##########
@@ -46,6 +46,12 @@ class BaseCallbackRequest(BaseModel):
"""File Path to use to run the callback"""
bundle_name: str
bundle_version: str | None
+ version_data: dict[str, Any] | None = None
+ """Optional structured metadata for the pinned bundle version (e.g. an S3
object manifest).
+
+ Populated only for pinned runs so the callback initializes the bundle
against the same
+ version the task ran with; ``None`` for unpinned runs.
Review Comment:
I agree with you. I generally err in favour of over-documenting but I
believe docstrings should not be too verbose because the extra context just
gets cutoff in IDE tooltips. I think you should keep the the 2 lines after the
first as a comment instead.
But this is not a major issue. It is up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
