takayoshi-makabe opened a new pull request, #69506:
URL: https://github.com/apache/airflow/pull/69506
`OpenAITriggerBatchOperator.execute_complete` used the trigger event without
validating it, branching deny-list style (only `status == "error"` raised,
everything else succeeded):
- **`cancelled` was marked SUCCESS**: the provider's own
`OpenAIBatchTrigger` emits `{"status": "cancelled"}` when the batch is
cancelled while the task is deferred, but only `error` raised — so the task
went green with no results. The non-deferrable path
(`OpenAIHook.wait_for_batch`) has raised for `CANCELLED`/`CANCELLING` since
#41554, so the two modes of the same operator disagreed.
- **`event=None`**: crashed with an opaque `TypeError: 'NoneType' object is
not subscriptable`.
- **Unrecognised `status`** (triggerer/worker version skew, custom trigger):
fell through into the success path.
Same fix shape as the anthropic provider in #69379: a
validate_execute_complete_event() helper plus allow-list branching (status !=
"success" raises).
Also fixes a missing `else` in `OpenAIBatchTrigger.run()` that yielded a
second, spurious `error` event after every terminal event (benign — only the
first event is consumed — but incorrect).
---
##### Was generative AI tooling used to co-author this PR?
- [x] Yes (please specify the tool below)
Claude Code
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
