BasPH commented on code in PR #68742:
URL: https://github.com/apache/airflow/pull/68742#discussion_r3535494718
##########
airflow-core/src/airflow/ui/public/i18n/locales/nl/common.json:
##########
@@ -18,10 +18,14 @@
"asset_other": "Assets",
"assetEvent_one": "Asset Event",
"assetEvent_other": "Asset Events",
+ "assetInactive": {
+ "tooltip": "Upstream asset is gedeactiveerd; de scheduler houdt
partitie-evaluatie vast totdat het opnieuw wordt geactiveerd."
Review Comment:
```suggestion
"tooltip": "Upstream asset is gedeactiveerd; de scheduler houdt
partitie-evaluatie vast tot de asset opnieuw wordt geactiveerd."
```
Lets make this more explicit
##########
airflow-core/src/airflow/ui/public/i18n/locales/nl/dag.json:
##########
@@ -179,12 +226,34 @@
"renderedTemplates": "Gerenderde templates",
"requiredActions": "Vereiste acties",
"runs": "Runs",
+ "storage": "Opslag",
"taskInstances": "Task Instances",
+ "taskStateStore": "Task State Store",
Review Comment:
I'm a bit in limbo about translating this. It's currently [not listed as a
reserved
word](https://github.com/apache/airflow/blob/main/.agents/skills/airflow-translations/SKILL.md?plain=1#L160-L176),
but I find it difficult to come up with a good Dutch translation. Maybe
"Taakstatusopslag"?
##########
airflow-core/src/airflow/ui/public/i18n/locales/nl/dag.json:
##########
@@ -40,9 +40,37 @@
"parseDuration": "Parse duur:",
"parsedAt": "Geparsed op:"
},
+ "deadlineAlerts": {
+ "completionRule": "Moet worden voltooid binnen {{interval}} van
{{reference}}",
+ "count_one": "{{count}} deadline",
+ "count_other": "{{count}} deadlines",
+ "referenceType": {
+ "AverageRuntimeDeadline": "Gemiddelde uitvoertijd",
+ "DagRunLogicalDateDeadline": "Logische datum",
+ "DagRunQueuedAtDeadline": "Wachttijd"
+ }
+ },
+ "deadlineStatus": {
+ "actual": "Werkelijk",
+ "expected": "Verwacht",
+ "finishedEarly": "Voltooid {{duration}} voor de deadline",
+ "finishedLate": "Voltooid {{duration}} na de deadline",
+ "label": "Deadline",
+ "met": "Behaald",
+ "missed": "Gemist",
+ "missedCount_one": "{{count}} Gemiste deadline",
+ "missedCount_other": "{{count}} Gemiste deadlines",
+ "mixedCount": "{{missedCount}} gemist, {{upcomingCount}} opkomend",
+ "stillRunning": "Nog steeds bezig",
Review Comment:
```suggestion
"stillRunning": "Nog bezig",
```
Would leave "steeds" out for conciseness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
