aaronsteers commented on code in PR #68882: URL: https://github.com/apache/airflow/pull/68882#discussion_r3537762641
########## providers/airbyte/docs/changelog.rst: ########## @@ -27,6 +27,29 @@ Changelog --------- +6.0.0 +..... + +Breaking changes +~~~~~~~~~~~~~~~~ + +.. note:: + This release upgrades the provider's ``airbyte-api`` dependency to the ``1.x`` series and switches + the underlying HTTP client from ``requests`` to ``httpx``. + + No changes are required for typical Dag authors: the ``AirbyteHook``, ``AirbyteTriggerSyncOperator``, + and ``AirbyteJobSensor`` public interfaces are unchanged, and the Airbyte connection configuration + (including the ``proxies`` extra) keeps the same format. + + Action is required only if your environment relies on the provider's transitive dependencies: + + * ``airbyte-api`` is now ``>=1.0.0,<2.0`` (previously ``>=0.52.0,<1.0.0``). The ``1.x`` SDK is built + on Pydantic models, so any code importing ``airbyte_api`` directly must pass request objects as + keyword arguments (e.g. ``GetJobRequest(job_id=...)``) and handle its stricter response validation. + * ``requests`` is no longer installed by this provider. If your code relied on it being pulled in + transitively, declare ``requests`` as an explicit dependency of your own project. Review Comment: @eladkal - I've reverted the major version bump. And I was a bit confused about whether I should or shouldn't bump the version at all, vs leaving that to the releaser. I believe I'm supposed to let that be bumped by the releaser, but can you confirm I have the headers and content correctly positioned in the changelog.rst file and a version number is expected to be prepended to that content during release? (I have also granted maintainers ability to add commits to this PR. Feel free to do the needed directly if easier. 😅) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
