ashb commented on code in PR #69565:
URL: https://github.com/apache/airflow/pull/69565#discussion_r3540108785


##########
airflow-core/src/airflow/models/taskmap.py:
##########
@@ -266,11 +266,13 @@ def expand_mapped_task(
                 dag_version_id=dag_version_id,
             )
             task.log.debug("Expanding TIs upserted %s", ti)
-            task_instance_mutation_hook(ti, dag_run=dr)
-            ti = session.merge(ti)
-            ti.context_carrier = new_task_run_carrier(dr.context_carrier)
-            ti.refresh_from_task(task, dag_run=dr)  # session.merge() loses 
task information.
-            all_expanded_tis.append(ti)
+            _add_and_prime_mapped_ti(
+                ti, task, dr, session=session, 
context_carrier=new_task_run_carrier(dr.context_carrier)

Review Comment:
   We always want a context carrier on TIs though? And this fn is only called 
on new TIs, where we always want to set context carrier?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to