pierrejeambrun commented on code in PR #69537:
URL: https://github.com/apache/airflow/pull/69537#discussion_r3543381344
##########
.pre-commit-config.yaml:
##########
@@ -1272,11 +1272,14 @@ repos:
files: ^shared/.*|^scripts/ci/prek/check_shared_mypy_hooks\.py$
require_serial: true
- id: check-migration-patterns
- name: Check migration files for anti-patterns (MIG001/MIG002/MIG003)
+ name: Check migration files for anti-patterns and style (MIG001-MIG004)
entry: ./scripts/ci/prek/check_migration_patterns.py
language: python
pass_filenames: true
- files: ^airflow-core/src/airflow/migrations/versions/.*\.py$
+ files: >
+ (?x)
+ ^airflow-core/src/airflow/migrations/versions/.*\.py$|
+ ^providers/.*/migrations/versions/.*\.py$
Review Comment:
I would probably remove providers from here.
(Providers have their own hooks, so it should live there I guess, in the
global provider precommits file probably )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
